[ https://issues.apache.org/jira/browse/ZOOKEEPER-1459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13806146#comment-13806146 ]
Flavio Junqueira commented on ZOOKEEPER-1459: --------------------------------------------- Both patches, from [~rakeshr] and [~davidlao], hang on org.apache.zookeeper.server.ZxidRolloverTest for me. [~davidlao] is right that a lot of tests fail on Windows because we don't close the txn log. I don't observe the same on unix and it seems to be due to the semantics of file deletion. [~davidlao], when you generate patches, the patch root should be the project root (e.g., src/java....). > Standalone ZooKeeperServer is not closing the transaction log files on > shutdown > ------------------------------------------------------------------------------- > > Key: ZOOKEEPER-1459 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1459 > Project: ZooKeeper > Issue Type: Bug > Components: server > Affects Versions: 3.4.0 > Reporter: Rakesh R > Assignee: Rakesh R > Fix For: 3.4.6, 3.5.0 > > Attachments: ZOOKEEPER-1459.patch, ZOOKEEPER-1459.patch, > ZOOKEEPER-1459.patch, ZOOKEEPER-1459.patch, ZOOKEEPER-1459.patch, > ZOOKEEPER-1459.patch, ZOOKEEPER-1459.patch > > > When shutdown the standalone ZK server, its only clearing the zkdatabase and > not closing the transaction log streams. When tries to delete the temporary > files in unit tests on windows, its failing. > ZooKeeperServer.java > {noformat} > if (zkDb != null) { > zkDb.clear(); > } > {noformat} > Suggestion to close the zkDb as follows, this inturn will take care > transaction logs: > {noformat} > if (zkDb != null) { > zkDb.clear(); > try { > zkDb.close(); > } catch (IOException ie) { > LOG.warn("Error closing logs ", ie); > } > } > {noformat} -- This message was sent by Atlassian JIRA (v6.1#6144)