----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20071/#review71262 -----------------------------------------------------------
./src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java <https://reviews.apache.org/r/20071/#comment116928> Why interrupt() here? Add comments please. ./src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java <https://reviews.apache.org/r/20071/#comment116929> Why interrupt()? ./src/java/main/org/apache/zookeeper/server/ZooKeeperCriticalThread.java <https://reviews.apache.org/r/20071/#comment116933> thName -> threadName ./src/java/main/org/apache/zookeeper/server/ZooKeeperCriticalThread.java <https://reviews.apache.org/r/20071/#comment116931> The logging is duplicate to that in notifyStopping(). I think we should remove the one in notifyStopping() because we might want to print exception stack. ./src/java/main/org/apache/zookeeper/server/ZooKeeperCriticalThread.java <https://reviews.apache.org/r/20071/#comment116932> this.getName() -> threadName ./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java <https://reviews.apache.org/r/20071/#comment116934> Why synchronized here not startup() method? Add some comments? ./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java <https://reviews.apache.org/r/20071/#comment116935> Same. Why synchronized here? Some comments will help prevent people in the future move it. ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java <https://reviews.apache.org/r/20071/#comment116936> Why interrupt? ./src/java/main/org/apache/zookeeper/server/quorum/LearnerZooKeeperServer.java <https://reviews.apache.org/r/20071/#comment116938> Isn't "running" set to false in super.shutdown()? ./src/java/main/org/apache/zookeeper/server/quorum/ObserverZooKeeperServer.java <https://reviews.apache.org/r/20071/#comment116939> Same.. it's always false. - Hongchao Deng On Feb. 5, 2015, 6:32 p.m., Rakesh R wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20071/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2015, 6:32 p.m.) > > > Review request for zookeeper, michim, Raul Gutierrez Segales, and Camille > Fournier. > > > Bugs: ZOOKEEPER-1907 > https://issues.apache.org/jira/browse/ZOOKEEPER-1907 > > > Repository: zookeeper > > > Description > ------- > > Improve the thread handling mechanism by detecting if any of the critical > thread dies. > Here the idea is to periodically checking the status of all the critical > threads in ZK server using DeathWatcherThread. > > > Diffs > ----- > > ./src/java/main/org/apache/zookeeper/server/ExitCode.java PRE-CREATION > ./src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java > 1657623 > ./src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java 1657623 > ./src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java > 1657623 > ./src/java/main/org/apache/zookeeper/server/ZooKeeperCriticalThread.java > 1657623 > ./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 1657623 > ./src/java/main/org/apache/zookeeper/server/ZooKeeperServerListener.java > PRE-CREATION > ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java > 1657623 > > ./src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java > 1657623 > > ./src/java/main/org/apache/zookeeper/server/quorum/FollowerZooKeeperServer.java > 1657623 > > ./src/java/main/org/apache/zookeeper/server/quorum/LeaderSessionTracker.java > 1657623 > > ./src/java/main/org/apache/zookeeper/server/quorum/LeaderZooKeeperServer.java > 1657623 > > ./src/java/main/org/apache/zookeeper/server/quorum/LearnerSessionTracker.java > 1657623 > > ./src/java/main/org/apache/zookeeper/server/quorum/LearnerZooKeeperServer.java > 1657623 > ./src/java/main/org/apache/zookeeper/server/quorum/LocalSessionTracker.java > 1657623 > > ./src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java > 1657623 > > ./src/java/main/org/apache/zookeeper/server/quorum/ObserverZooKeeperServer.java > 1657623 > > ./src/java/main/org/apache/zookeeper/server/quorum/ProposalRequestProcessor.java > 1657623 > > ./src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyRequestProcessor.java > 1657623 > > ./src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyZooKeeperServer.java > 1657623 > > ./src/java/main/org/apache/zookeeper/server/quorum/UpgradeableSessionTracker.java > 1657623 > ./src/java/test/org/apache/zookeeper/server/PrepRequestProcessorTest.java > 1657623 > ./src/java/test/org/apache/zookeeper/server/SessionTrackerTest.java 1657623 > ./src/java/test/org/apache/zookeeper/server/ZooKeeperThreadTest.java > 1657623 > > ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorConcurrencyTest.java > 1657623 > ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorTest.java > 1657623 > ./src/java/test/org/apache/zookeeper/test/ClientBase.java 1657623 > ./src/java/test/org/apache/zookeeper/test/SessionTrackerCheckTest.java > 1657623 > > Diff: https://reviews.apache.org/r/20071/diff/ > > > Testing > ------- > > yet to be inlcuded > > > Thanks, > > Rakesh R > >
