> On Feb. 5, 2015, 6:50 p.m., Hongchao Deng wrote: > > ./src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java, line > > 155 > > <https://reviews.apache.org/r/20071/diff/4-5/?file=845238#file845238line155> > > > > Why interrupt()?
its not required, removed. > On Feb. 5, 2015, 6:50 p.m., Hongchao Deng wrote: > > ./src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java, line > > 147 > > <https://reviews.apache.org/r/20071/diff/4-5/?file=845237#file845237line147> > > > > Why interrupt() here? > > Add comments please. > > Rakesh R wrote: > When we catch and swallow InterruptedException, one common pattern is - > call Thread.currentThread().interrupt() afterward, so that the interrupt > status isn't lost. > > Rakesh R wrote: > After second thought your point is valid, since this is inside thread > there is no effect on setting the status back to the thread. I will remove > this. its not required, removed. > On Feb. 5, 2015, 6:50 p.m., Hongchao Deng wrote: > > ./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java, line 465 > > <https://reviews.apache.org/r/20071/diff/4-5/?file=845241#file845241line465> > > > > Same. Why synchronized here? Some comments will help prevent people in > > the future move it. Modified the synchronization to method level > On Feb. 5, 2015, 6:50 p.m., Hongchao Deng wrote: > > ./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java, line 408 > > <https://reviews.apache.org/r/20071/diff/4-5/?file=845241#file845241line408> > > > > Why synchronized here not startup() method? Add some comments? Made synchronization at startup() method - Rakesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20071/#review71262 ----------------------------------------------------------- On Feb. 19, 2015, 3:23 a.m., Rakesh R wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20071/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2015, 3:23 a.m.) > > > Review request for zookeeper, michim, Raul Gutierrez Segales, and Camille > Fournier. > > > Bugs: ZOOKEEPER-1907 > https://issues.apache.org/jira/browse/ZOOKEEPER-1907 > > > Repository: zookeeper > > > Description > ------- > > Improve the thread handling mechanism by detecting if any of the critical > thread dies. > Here the idea is to periodically checking the status of all the critical > threads in ZK server using DeathWatcherThread. > > > Diffs > ----- > > ./src/java/main/org/apache/zookeeper/server/ExitCode.java PRE-CREATION > ./src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java > 1660779 > ./src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java 1660779 > ./src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java > 1660779 > ./src/java/main/org/apache/zookeeper/server/ZooKeeperCriticalThread.java > 1660779 > ./src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 1660779 > ./src/java/main/org/apache/zookeeper/server/ZooKeeperServerListener.java > PRE-CREATION > ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java > 1660779 > > ./src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java > 1660779 > > ./src/java/main/org/apache/zookeeper/server/quorum/FollowerZooKeeperServer.java > 1660779 > > ./src/java/main/org/apache/zookeeper/server/quorum/LeaderSessionTracker.java > 1660779 > > ./src/java/main/org/apache/zookeeper/server/quorum/LeaderZooKeeperServer.java > 1660779 > > ./src/java/main/org/apache/zookeeper/server/quorum/LearnerSessionTracker.java > 1660779 > > ./src/java/main/org/apache/zookeeper/server/quorum/LearnerZooKeeperServer.java > 1660779 > ./src/java/main/org/apache/zookeeper/server/quorum/LocalSessionTracker.java > 1660779 > > ./src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java > 1660779 > > ./src/java/main/org/apache/zookeeper/server/quorum/ObserverZooKeeperServer.java > 1660779 > > ./src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyRequestProcessor.java > 1660779 > > ./src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyZooKeeperServer.java > 1660779 > > ./src/java/main/org/apache/zookeeper/server/quorum/UpgradeableSessionTracker.java > 1660779 > ./src/java/test/org/apache/zookeeper/server/ZooKeeperThreadTest.java > 1660779 > > ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorConcurrencyTest.java > 1660779 > ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorTest.java > 1660779 > ./src/java/test/org/apache/zookeeper/test/ClientBase.java 1660779 > ./src/java/test/org/apache/zookeeper/test/SessionTrackerCheckTest.java > 1660779 > > Diff: https://reviews.apache.org/r/20071/diff/ > > > Testing > ------- > > yet to be inlcuded > > > Thanks, > > Rakesh R > >
