[ https://issues.apache.org/jira/browse/ZOOKEEPER-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14526237#comment-14526237 ]
Hadoop QA commented on ZOOKEEPER-2171: -------------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12730100/ZOOKEEPER-2171.patch against trunk revision 1677460. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 17 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2671//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2671//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2671//console This message is automatically generated. > avoid reverse lookups in QuorumCnxManager > ----------------------------------------- > > Key: ZOOKEEPER-2171 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2171 > Project: ZooKeeper > Issue Type: Bug > Components: quorum > Reporter: Raul Gutierrez Segales > Assignee: Raul Gutierrez Segales > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2171.patch, ZOOKEEPER-2171.patch, > ZOOKEEPER-2171.patch, ZOOKEEPER-2171.patch, ZOOKEEPER-2171.patch, > ZOOKEEPER-2171.patch > > > Apparently, ZOOKEEPER-107 (via a quick git-blame look) introduced a bunch of > getHostName() calls in QCM. Besides the overhead, these can cause problems > when mixed with failing/mis-configured DNS servers. > It would be nice to reduce them, if that doesn't affect operational > correctness. -- This message was sent by Atlassian JIRA (v6.3.4#6332)