[ https://issues.apache.org/jira/browse/ZOOKEEPER-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14537381#comment-14537381 ]
Hongchao Deng commented on ZOOKEEPER-2171: ------------------------------------------ Great work folks! Just mention one discrepancy I found in 'CHANGE.txt': 1. in branch-3.5, it shows in bug fixes 2. in trunk, it shows in improvement. > avoid reverse lookups in QuorumCnxManager > ----------------------------------------- > > Key: ZOOKEEPER-2171 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2171 > Project: ZooKeeper > Issue Type: Bug > Components: quorum > Reporter: Raul Gutierrez Segales > Assignee: Raul Gutierrez Segales > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2171.patch, ZOOKEEPER-2171.patch > > > Apparently, ZOOKEEPER-107 (via a quick git-blame look) introduced a bunch of > getHostName() calls in QCM. Besides the overhead, these can cause problems > when mixed with failing/mis-configured DNS servers. > It would be nice to reduce them, if that doesn't affect operational > correctness. -- This message was sent by Atlassian JIRA (v6.3.4#6332)