[ https://issues.apache.org/jira/browse/ZOOKEEPER-2182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14533248#comment-14533248 ]
Hadoop QA commented on ZOOKEEPER-2182: -------------------------------------- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12731238/ZOOKEEPER-2182.001.patch against trunk revision 1678032. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 20 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2680//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2680//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2680//console This message is automatically generated. > Several test suites are not running during pre-commit, because their names do > not end with "Test". > -------------------------------------------------------------------------------------------------- > > Key: ZOOKEEPER-2182 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2182 > Project: ZooKeeper > Issue Type: Bug > Components: tests > Reporter: Chris Nauroth > Assignee: Chris Nauroth > Attachments: ZOOKEEPER-2182.001.patch > > > In build.xml, the {{<junit>}} task definition uses an include pattern of > {{\*\*/\*$\{test.category\}Test.java}}. This is important so that we don't > accidentally try to run utility classes like {{PortAssignment}} or > {{TestableZooKeeper}} as if they were JUnit suites. However, several test > suites are misnamed so that they don't satisfy this pattern, and therefore > pre-commit hasn't been running them. > {{ClientRetry}} > {{ReconfigFailureCases}} > {{WatchEventWhenAutoReset}} -- This message was sent by Atlassian JIRA (v6.3.4#6332)