[ https://issues.apache.org/jira/browse/ZOOKEEPER-2182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14537383#comment-14537383 ]
Hongchao Deng commented on ZOOKEEPER-2182: ------------------------------------------ Committed: trunk: https://github.com/apache/zookeeper/commit/029d6299e006ca697c3d6f9953b3194a7c33bf19 branch-3.5: https://github.com/apache/zookeeper/commit/5b06e01de19135b6fe38a947dd1238877a647e49 > Several test suites are not running during pre-commit, because their names do > not end with "Test". > -------------------------------------------------------------------------------------------------- > > Key: ZOOKEEPER-2182 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2182 > Project: ZooKeeper > Issue Type: Bug > Components: tests > Affects Versions: 3.5.0 > Reporter: Chris Nauroth > Assignee: Chris Nauroth > Fix For: 3.5.1, 3.6.0 > > Attachments: ZOOKEEPER-2182.001.patch > > > In build.xml, the {{<junit>}} task definition uses an include pattern of > {{\*\*/\*$\{test.category\}Test.java}}. This is important so that we don't > accidentally try to run utility classes like {{PortAssignment}} or > {{TestableZooKeeper}} as if they were JUnit suites. However, several test > suites are misnamed so that they don't satisfy this pattern, and therefore > pre-commit hasn't been running them. > {{ClientRetry}} > {{ReconfigFailureCases}} > {{WatchEventWhenAutoReset}} -- This message was sent by Atlassian JIRA (v6.3.4#6332)