[
https://issues.apache.org/jira/browse/ZOOKEEPER-2182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14539278#comment-14539278
]
Rakesh R commented on ZOOKEEPER-2182:
-------------------------------------
Thanks all for taking care this. [~hdeng] am closing this jira as I think the
changes has been applied/committed. Please feel to re-open if anything to be
done.
> Several test suites are not running during pre-commit, because their names do
> not end with "Test".
> --------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-2182
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2182
> Project: ZooKeeper
> Issue Type: Bug
> Components: tests
> Affects Versions: 3.5.0
> Reporter: Chris Nauroth
> Assignee: Chris Nauroth
> Fix For: 3.5.1, 3.6.0
>
> Attachments: ZOOKEEPER-2182.001.patch
>
>
> In build.xml, the {{<junit>}} task definition uses an include pattern of
> {{\*\*/\*$\{test.category\}Test.java}}. This is important so that we don't
> accidentally try to run utility classes like {{PortAssignment}} or
> {{TestableZooKeeper}} as if they were JUnit suites. However, several test
> suites are misnamed so that they don't satisfy this pattern, and therefore
> pre-commit hasn't been running them.
> {{ClientRetry}}
> {{ReconfigFailureCases}}
> {{WatchEventWhenAutoReset}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
