> On May 10, 2015, 4:30 a.m., michim wrote:
> > http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java,
> > line 89
> > <https://reviews.apache.org/r/34023/diff/1/?file=954728#file954728line89>
> >
> > do we need to change the protocol version from 0xffff0000 to -65536?
it's not a change, it's the same (2’s complement):
```
$ cat Test.java
class Test {
public static void main(String args[]) {
System.out.println(String.format("%d", 0xffff0000));
}
}
$ java Test
-65536
```
- Raul
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34023/#review83176
-----------------------------------------------------------
On May 10, 2015, 4:19 a.m., michim wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34023/
> -----------------------------------------------------------
>
> (Updated May 10, 2015, 4:19 a.m.)
>
>
> Review request for zookeeper.
>
>
> Repository: zookeeper
>
>
> Description
> -------
>
> ZOOKEEPER-2186 QuorumCnxManager#receiveConnection may crash with random input
>
>
> Diffs
> -----
>
>
> http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java
> 1678536
>
> http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/test/org/apache/zookeeper/test/CnxManagerTest.java
> 1678536
>
> Diff: https://reviews.apache.org/r/34023/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> michim
>
>
