> On May 10, 2015, 4:29 a.m., Hongchao Deng wrote: > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java, > > line 260 > > <https://reviews.apache.org/r/34023/diff/1/?file=954728#file954728line260> > > > > Maybe you can reuse the field here > > > > BinaryInputArchive.UNREASONBLE_LENGTH > > > > to keep error messages consistent.
We don't use that class here, so I rather keep them separate. - Raul ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34023/#review83177 ----------------------------------------------------------- On May 10, 2015, 4:19 a.m., michim wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34023/ > ----------------------------------------------------------- > > (Updated May 10, 2015, 4:19 a.m.) > > > Review request for zookeeper. > > > Repository: zookeeper > > > Description > ------- > > ZOOKEEPER-2186 QuorumCnxManager#receiveConnection may crash with random input > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java > 1678536 > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/test/org/apache/zookeeper/test/CnxManagerTest.java > 1678536 > > Diff: https://reviews.apache.org/r/34023/diff/ > > > Testing > ------- > > > Thanks, > > michim > >
