> On May 10, 2015, 4:30 a.m., michim wrote: > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java, > > line 250 > > <https://reviews.apache.org/r/34023/diff/1/?file=954728#file954728line250> > > > > - what happens when the previous version sends 0xffff0000? > > - we don't need to handle messages that don't contain protocol version > > any more?
My bad, internally we don't have old clusters anymore so I removed that case. I'll cover it too. > On May 10, 2015, 4:30 a.m., michim wrote: > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java, > > line 328 > > <https://reviews.apache.org/r/34023/diff/1/?file=954728#file954728line328> > > > > why did this check get removed? it can't be null anymore, we'd return before the assignment if that's the case. - Raul ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34023/#review83176 ----------------------------------------------------------- On May 10, 2015, 4:19 a.m., michim wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34023/ > ----------------------------------------------------------- > > (Updated May 10, 2015, 4:19 a.m.) > > > Review request for zookeeper. > > > Repository: zookeeper > > > Description > ------- > > ZOOKEEPER-2186 QuorumCnxManager#receiveConnection may crash with random input > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java > 1678536 > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/test/org/apache/zookeeper/test/CnxManagerTest.java > 1678536 > > Diff: https://reviews.apache.org/r/34023/diff/ > > > Testing > ------- > > > Thanks, > > michim > >
