[ https://issues.apache.org/jira/browse/ZOOKEEPER-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15180546#comment-15180546 ]
Hadoop QA commented on ZOOKEEPER-2195: -------------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12791531/ZOOKEEPER-2195.patch against trunk revision 1733525. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3085//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3085//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3085//console This message is automatically generated. > fsync.warningthresholdms in zoo.cfg not working > ----------------------------------------------- > > Key: ZOOKEEPER-2195 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2195 > Project: ZooKeeper > Issue Type: Bug > Components: quorum > Affects Versions: 3.4.6, 3.5.0 > Reporter: David Fan > Assignee: Biju Nair > Priority: Trivial > Attachments: ZOOKEEPER-2195.patch > > > Config fsync.warningthresholdms in zoo.cfg does not work. > I find QuorumPeerConfig.parseProperties give fsync.warningthresholdms a > prefix like "zookeeper.fsync.warningthresholdms". But in class FileTxnLog > where fsync.warningthresholdms is used, code is > :Long.getLong("fsync.warningthresholdms", 1000),without prefix "zookeeper.", > therefore can not get fsync.warningthresholdms's value. > I wonder the speed of fsync, need this config to see whether the speed is > good enough. -- This message was sent by Atlassian JIRA (v6.3.4#6332)