[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15181928#comment-15181928
 ] 

Dmitry Ryabkov commented on ZOOKEEPER-2195:
-------------------------------------------

[~gsbiju] Looks fine to me, as long as you don't modify the config file 
property name (which I think you don't). The config file property names get 
"zookeeper." appended in front of them in 
http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java,
 parseProperties() method and then set as system properties. Now with these two 
patches everything looks in sync to me.

> fsync.warningthresholdms in zoo.cfg not working
> -----------------------------------------------
>
>                 Key: ZOOKEEPER-2195
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2195
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: quorum
>    Affects Versions: 3.4.6, 3.5.0
>            Reporter: David Fan
>            Assignee: Biju Nair
>            Priority: Trivial
>         Attachments: ZOOKEEPER-2195-DOC.patch, ZOOKEEPER-2195.patch
>
>
> Config fsync.warningthresholdms in zoo.cfg does not work.
> I find QuorumPeerConfig.parseProperties give fsync.warningthresholdms a 
> prefix like "zookeeper.fsync.warningthresholdms".  But in class FileTxnLog 
> where fsync.warningthresholdms is used, code is 
> :Long.getLong("fsync.warningthresholdms", 1000),without prefix "zookeeper.", 
> therefore can not get fsync.warningthresholdms's value.
> I wonder the speed of fsync, need this config to see whether the speed is 
> good enough.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to