[ https://issues.apache.org/jira/browse/ZOOKEEPER-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15188371#comment-15188371 ]
Patrick Hunt commented on ZOOKEEPER-2195: ----------------------------------------- Good find. I like this change, but I do have one concern - it's not backward compatible. I realize the current state is broken for people who try to put it into the config, however it currently works as documented for folks that just set the java system property. My request is: can you update the patch so that it works for either case (seems like it should be simple). Basically in the java code, if the z.f.w is set use that, if not fall back to f.w system property in case that is set. Does that make sense? > fsync.warningthresholdms in zoo.cfg not working > ----------------------------------------------- > > Key: ZOOKEEPER-2195 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2195 > Project: ZooKeeper > Issue Type: Bug > Components: quorum > Affects Versions: 3.4.6, 3.5.0 > Reporter: David Fan > Assignee: Biju Nair > Priority: Trivial > Attachments: ZOOKEEPER-2195-DOC.patch, ZOOKEEPER-2195.patch > > > Config fsync.warningthresholdms in zoo.cfg does not work. > I find QuorumPeerConfig.parseProperties give fsync.warningthresholdms a > prefix like "zookeeper.fsync.warningthresholdms". But in class FileTxnLog > where fsync.warningthresholdms is used, code is > :Long.getLong("fsync.warningthresholdms", 1000),without prefix "zookeeper.", > therefore can not get fsync.warningthresholdms's value. > I wonder the speed of fsync, need this config to see whether the speed is > good enough. -- This message was sent by Atlassian JIRA (v6.3.4#6332)