Hello William, Thank you for your interest in contributing to ZooKeeper!
In which version of ZooKeeper did you see this dependency on an old Netty version? My best guess is that it was some version in the ZooKeeper 3.3 line. At that time, BookKeeper was included as a contrib module inside ZooKeeper, and BookKeeper had this dependency in its ivy.xml: <dependency org="org.jboss.netty" name="netty" rev="3.1.5.GA" /> This is no longer an issue in more recent ZooKeeper releases (the 3.4 and 3.5 lines). BookKeeper has moved to its own top-level Apache project, so patches related to its dependencies wouldn't go here in ZooKeeper. At this point, ZooKeeper does also use Netty itself directly, but it's a newer version (3.7.0.Final in ZooKeeper 3.4 and 3.7.1.Final in ZooKeeper 3.5). If the above makes sense, then I suspect there wouldn't be a need for your patch anymore. However, even if that's the case, thank you for offering to donate it. Apache projects love seeing new contributors. If you have the time and the interest, I'd encourage you to look for other ways to contribute to ZooKeeper or any other Apache project. More details on our contribution process are available here: https://wiki.apache.org/hadoop/ZooKeeper/HowToContribute --Chris Nauroth On 3/22/16, 12:09 PM, "William L. Thomson Jr." <wlt...@o-sinc.com> wrote: >I was looking into packaging Hadoop on Gentoo which had a few >dependencies. >One of which is Zookeeper, a indirect dependency of Curator. The first >thing I >noticed was Zookeeper depends on an older version of Netty in the >org.jboss >package. Gentoo does not have this old version of Netty packaged. Rather >than >package an older Netty for Zookeeper. I started updating Zookeeper code >for >Netty. > >But I am not familiar with Netty or Zookeeper, so in short I have no idea >what >I am doing or did... I did find some documents that were very helpful in >the >changes with Netty. I have done I believe most of the work ~80-90%, but >still >a few things to code for newer Netty. Not to mention test the changes, >and not >being familiar with Zookeeper. Not sure how I can easily test the changes >to >Zookeeper usage of Netty. > >I did this some time back and I have not touched it since. I rather pass >on my >work rather than toss. It is not complete enough to commit to say github >and >submit a PR. Not sure if I can post patches here to the list, or if there >is >someone I can email or pastebin the patches to that can do something with >them. Ideally finish off my work and get Zookeeper updated for a newer >Netty. > >What I did not do, was to update the build system for a newer Netty. >Gentoo >does not use gradle, maven, ivy, etc. I had modified the ant build.xml to >bypass ivy and just use ant with dependencies provided by portage, >Gentoo's >packaging system. > >Hopefully you all are receptive to updating Zookeeper to use a newer >version >of Netty, and my effort thus far will be beneficial to others. > >-- >William L. Thomson Jr. >Obsidian-Studios, Inc. >http://www.obsidian-studios.com >
