Github user revans2 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/180#discussion_r102283801
--- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java ---
@@ -303,15 +305,38 @@ public void loadData() throws IOException,
InterruptedException {
public void takeSnapshot(){
--- End diff --
@flier Having SyncRequestProcessor look at the number of snapshot files
feels like a bit of a hack, but I am not expert here. I would be fine with
having SyncRequestProcessor delegate all throttling of snapshots to
ZooKeeperServer, but then we need some sort of synchronization to prevent a
snapshot from being taken when it is not in a proper state (during the ZABP
sync phase).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
