Github user revans2 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/180#discussion_r102222749
--- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java ---
@@ -303,15 +305,38 @@ public void loadData() throws IOException,
InterruptedException {
public void takeSnapshot(){
try {
+ lastSnapshotZxid = zkDb.getDataTreeLastProcessedZxid();
+ isGeneratingSnapshot.incrementAndGet();
+
txnLogFactory.save(zkDb.getDataTree(),
zkDb.getSessionWithTimeOuts());
} catch (IOException e) {
LOG.error("Severe unrecoverable error, exiting", e);
// This is a severe error that we cannot recover from,
// so we need to exit
System.exit(10);
+ } finally {
+ isGeneratingSnapshot.decrementAndGet();
}
}
+ public boolean maybeTakeSnapshot() {
--- End diff --
Could you add some javadocs here? It would be nice to explain the
difference between takeSnapshot and maybeTakeSnapshot.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
