Github user eribeiro commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/180#discussion_r102232941
  
    --- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java ---
    @@ -303,15 +305,38 @@ public void loadData() throws IOException, 
InterruptedException {
     
         public void takeSnapshot(){
    --- End diff --
    
    +1. This is the reason why I advocated the use of `AtomicBoolean` instead 
of `AtomicInteger` to provide mutual exclusion on this code snippet.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to