[
https://issues.apache.org/jira/browse/ZOOKEEPER-2770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16085104#comment-16085104
]
ASF GitHub Bot commented on ZOOKEEPER-2770:
-------------------------------------------
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/307#discussion_r127116226
--- Diff:
src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java ---
@@ -430,6 +432,7 @@ public void processRequest(Request request) {
// the client and leader disagree on where the client is most
// recently attached (and therefore invalid SESSION MOVED
generated)
cnxn.sendCloseSession();
+ request.checkLatency();
--- End diff --
I see that both `request.checkLatency()` and
`zks.serverStats().updateLatency(request.createTime);` (a few lines above) are
dealing with the same matter (request latency) even though on radical different
positions.
IMHO, `zks.serverStats().updateLatency(request.createTime);` should be
moved to the line position where `request.checkLatency()` currently is and to
move the if condition from `request.checkLatency()` to
`zks.serverStats().updateLatency(request.createTime);`, eventually getting rid
of `request.checkLatency()`. Could this raise some unexpected bugs?
@karanmehta93 @hanm, wdyt?
> ZooKeeper slow operation log
> ----------------------------
>
> Key: ZOOKEEPER-2770
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2770
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Karan Mehta
> Attachments: ZOOKEEPER-2770.001.patch, ZOOKEEPER-2770.002.patch,
> ZOOKEEPER-2770.003.patch
>
>
> Log the client and request details if the server discovers, when finally
> processing the request, that the current time minus arrival time of the
> request is beyond a configured threshold.
> Look at the HBase {{responseTooSlow}} feature for inspiration.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
