[
https://issues.apache.org/jira/browse/ZOOKEEPER-2770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16085107#comment-16085107
]
ASF GitHub Bot commented on ZOOKEEPER-2770:
-------------------------------------------
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/307#discussion_r127117526
--- Diff:
src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java ---
@@ -430,6 +432,7 @@ public void processRequest(Request request) {
// the client and leader disagree on where the client is most
// recently attached (and therefore invalid SESSION MOVED
generated)
cnxn.sendCloseSession();
+ request.checkLatency();
--- End diff --
On a related note, besides logging those slow requests, wouldn't be nice to
expose a counter of how many requests were above the latency threshold and
store it in `zks.serverStats()` so that it could be exposed as metric via JMX?
Going even further, we could expose other metrics related to slow requests
like average time & 99% percentiles as suggested by @tdunning
> ZooKeeper slow operation log
> ----------------------------
>
> Key: ZOOKEEPER-2770
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2770
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Karan Mehta
> Attachments: ZOOKEEPER-2770.001.patch, ZOOKEEPER-2770.002.patch,
> ZOOKEEPER-2770.003.patch
>
>
> Log the client and request details if the server discovers, when finally
> processing the request, that the current time minus arrival time of the
> request is beyond a configured threshold.
> Look at the HBase {{responseTooSlow}} feature for inspiration.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
