[
https://issues.apache.org/jira/browse/ZOOKEEPER-2770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16085102#comment-16085102
]
ASF GitHub Bot commented on ZOOKEEPER-2770:
-------------------------------------------
Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/307#discussion_r127110211
--- Diff: src/java/main/org/apache/zookeeper/server/Request.java ---
@@ -121,6 +128,13 @@ public void setTxn(Record txn) {
this.txn = txn;
}
+ public void checkLatency() {
+ long requestLatency = Time.currentElapsedTime() - this.createTime;
+ if(QuorumPeerConfig.getWarnResponseTime() > -1 && requestLatency >
QuorumPeerConfig.getWarnResponseTime()) {
--- End diff --
nit: space between `if` and `(`.
You can reduce the size of the `if` expression and avoid an unnecessary
call to the same method in the same expression by doing:
``` java
long warnRequestThreshold = QuorumPeerConfig.getWarnRequestTime()
if (warnRequestThreshold > -1 && requestLatency > warnRequestThreshold) {
```
> ZooKeeper slow operation log
> ----------------------------
>
> Key: ZOOKEEPER-2770
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2770
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Karan Mehta
> Attachments: ZOOKEEPER-2770.001.patch, ZOOKEEPER-2770.002.patch,
> ZOOKEEPER-2770.003.patch
>
>
> Log the client and request details if the server discovers, when finally
> processing the request, that the current time minus arrival time of the
> request is beyond a configured threshold.
> Look at the HBase {{responseTooSlow}} feature for inspiration.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
