[
https://issues.apache.org/jira/browse/ZOOKEEPER-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435465#comment-16435465
]
ASF GitHub Bot commented on ZOOKEEPER-3019:
-------------------------------------------
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/501#discussion_r181059907
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -146,6 +149,16 @@ public FileTxnLog(File logDir) {
this.logDir = logDir;
}
+ /**
+ * constructor for FileTxnLog. Take the directory
+ * where the txnlogs are stored
+ * @param logDir the directory where the txnlogs are stored
--- End diff --
Description for `serverStats` param is missing.
> Add a metric to track number of slow fsyncs
> -------------------------------------------
>
> Key: ZOOKEEPER-3019
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3019
> Project: ZooKeeper
> Issue Type: Improvement
> Components: jmx, server
> Affects Versions: 3.5.3, 3.4.11
> Reporter: Norbert Kalmar
> Assignee: Norbert Kalmar
> Priority: Major
>
> Add jmx bean and Command to ZooKeeper server to expose the the number of slow
> fsyncs as a metric.
> FileTxnLog.commit() should count the number of times fsync exceedsÂ
> fsyncWarningThresholdMS.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
