[jira] [Commented] (ZOOKEEPER-3019) Add a metric to track number of slow fsyncs

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435466#comment-16435466
 ] 

ASF GitHub Bot commented on ZOOKEEPER-3019:
-------------------------------------------

Github user anmolnar commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/501#discussion_r181060856
  
    --- Diff: src/java/main/org/apache/zookeeper/server/ServerStats.java ---
    @@ -32,6 +32,7 @@
         private long minLatency = Long.MAX_VALUE;
         private long totalLatency = 0;
         private long count = 0;
    +    private long fsyncThresholdExceedCount = 0L;
    --- End diff --
    
    What do you think about using `AtomicLong` instead of synchronising every 
access?


> Add a metric to track number of slow fsyncs
> -------------------------------------------
>
>                 Key: ZOOKEEPER-3019
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3019
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: jmx, server
>    Affects Versions: 3.5.3, 3.4.11
>            Reporter: Norbert Kalmar
>            Assignee: Norbert Kalmar
>            Priority: Major
>
> Add jmx bean and Command to ZooKeeper server to expose the the number of slow 
> fsyncs as a metric.
> FileTxnLog.commit() should count the number of times fsync exceeds 
> fsyncWarningThresholdMS.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)