[
https://issues.apache.org/jira/browse/ZOOKEEPER-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435832#comment-16435832
]
ASF GitHub Bot commented on ZOOKEEPER-3019:
-------------------------------------------
Github user edwardoliveira commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/501#discussion_r181134958
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java ---
@@ -55,6 +53,7 @@
private final File snapDir;
private TxnLog txnLog;
private SnapShot snapLog;
+ private ServerStats serverStats;
--- End diff --
Maybe I am missing something pretty obvious here, but it seems that
`serverStats` is passed to `FileTxnLog`, but there is no place in this class
where it passes `serverStats` to `FileTxnLog`.
> Add a metric to track number of slow fsyncs
> -------------------------------------------
>
> Key: ZOOKEEPER-3019
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3019
> Project: ZooKeeper
> Issue Type: Improvement
> Components: jmx, server
> Affects Versions: 3.5.3, 3.4.11
> Reporter: Norbert Kalmar
> Assignee: Norbert Kalmar
> Priority: Major
>
> Add jmx bean and Command to ZooKeeper server to expose the the number of slow
> fsyncs as a metric.
> FileTxnLog.commit() should count the number of times fsync exceedsÂ
> fsyncWarningThresholdMS.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
