GitHub user anmolnar opened a pull request:
https://github.com/apache/zookeeper/pull/545
ZOOKEEPER-2261 When only secureClientPort is configured connections,
configuration, connection_stat_reset, and stats admin commands throw
NullPointerException
Root cause of the issue is that property getter returns the non-secure
ServerCnxnFactory instance always. When Quorum SSL is enabled, we set a
separate field which is the secure instance.
Property getter should detect the scenario and return the proper instance.
First commit contains some refactoring: shuffling the existing
ZooKeeperServer tests to relevant places.
Second commit is the actual fix + new unit tests.
Sorry about indentation changes, but `FileTxnLogTest.java` was indented by
2 spaces instead of 4.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/anmolnar/zookeeper ZOOKEEPER-2261
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/545.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #545
----
commit 1fc048f96db7ac9485508a4179cbe8a1e0ef06d8
Author: Andor Molnar <andor@...>
Date: 2018-06-15T15:26:17Z
ZOOKEEPER-2261. Refactor ZooKeeperServerTest class and move existing tests
to proper places
commit b34ba0768bef08a8734b89ba5a872151dc98fd49
Author: Andor Molnar <andor@...>
Date: 2018-06-15T15:27:55Z
ZOOKEEPER-2261. Return secure factory instance if present + unit tests
----
---
