Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/545#discussion_r205729651
--- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java ---
@@ -866,6 +866,9 @@ public void setServerCnxnFactory(ServerCnxnFactory
factory) {
}
public ServerCnxnFactory getServerCnxnFactory() {
+ if (secureServerCnxnFactory != null) {
+ return secureServerCnxnFactory;
+ }
return serverCnxnFactory;
}
--- End diff --
I will look into it. Original issue was on the caller side which didn't
have the logic to probe which ServerCnxnFactory is available, so I probably
have to make it more clever.
Though I'm not entirely convinced that it should be the caller's
responsibility to deal with the problem. He just want something that implements
the interface. Why should make this their problem?
---
