Github user breed commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/545#discussion_r205663822 --- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java --- @@ -866,6 +866,9 @@ public void setServerCnxnFactory(ServerCnxnFactory factory) { } public ServerCnxnFactory getServerCnxnFactory() { + if (secureServerCnxnFactory != null) { + return secureServerCnxnFactory; + } return serverCnxnFactory; } --- End diff -- i don't feel strongly about it, but i like @hanm 's idea.
---