Justin Il giorno mar 9 feb 2021 alle ore 13:46 Justin Ling Mao < maoling199210...@sina.com> ha scritto:
> Oops, it's my blame. I'm very sorry for my mistakes. Since these days the > CI is in disorder and it's a typo, so I'm not waiting for CI check and > forgot that an UT has covered this change although I wrote these related > codes. It's all my mistake and I will summarize our submission process and > this accident. I will write another letter to discuss the commit rules and > how to improve our code review throughput > No problem, do not worry too much There is no hurry in committing a patch, we aren't going to cut a release soon, and even in that case we can always wait, as ASF we do not have a strict schedule and we do not have to provide hotfix releases to customers. Even in case of a security issue we must take our time, Quality is one of the most important values for our community side topic: If CI is not working properly we have to work on it Enrico > > ----- Original Message ----- > From: Andor Molnar <an...@apache.org> > To: DevZooKeeper <dev@zookeeper.apache.org> > Subject: Commit 4faf507 broke the build > Date: 2021-02-09 19:43 > > Hi, > I noticed that the latest commit 4faf507 ZOOKEEPER-4007: A typo in the > ZKUtil#validateFileInput method broke the build, because the unit test has > not been amended. > I reverted the commit to fix the build. Please create new PR with a proper > patch. > Has the committer verified that the build is green before submitting it? > Andor >
