I’m sorry Justin. There’s no excuse for a mistake like this. We should not show mercy for anybody, otherwise it would erode the trust in our community. Your committership is now revoked.
Just kidding. Don’t worry at all. ;-) I reverted the patch, so now please create a new PR with all the required changes included. Also I second Enrico’s comment: if CI is in bad shape, we should fix it. Regards, Andor > On 2021. Feb 9., at 13:45, Justin Ling Mao <maoling199210...@sina.com> wrote: > > Oops, it's my blame. I'm very sorry for my mistakes. Since these days the CI > is in disorder and it's a typo, so I'm not waiting for CI check and forgot > that an UT has covered this change although I wrote these related codes. It's > all my mistake and I will summarize our submission process and this accident. > I will write another letter to discuss the commit rules and how to improve > our code review throughput > > > ----- Original Message ----- > From: Andor Molnar <an...@apache.org> > To: DevZooKeeper <dev@zookeeper.apache.org> > Subject: Commit 4faf507 broke the build > Date: 2021-02-09 19:43 > > Hi, > I noticed that the latest commit 4faf507 ZOOKEEPER-4007: A typo in the > ZKUtil#validateFileInput method broke the build, because the unit test has > not been amended. > I reverted the commit to fix the build. Please create new PR with a proper > patch. > Has the committer verified that the build is green before submitting it? > Andor
