Just fyi I was going to cast my +1. As pointed out by Damien we can fix up the release notes after the release, it is o ly a website change, no need to nuke an RC.
+1 (binding) Built sources and run all tests on Ubuntu + jdk8 Run smoke tests on mac jdk8 and jdk17ea Validated checksums and signatures Validated rat and checkstyle Mohammad if you did not delete the Maven repo and the staged artifacts IMHO we can continue to vote this RC. But it is your call as RM Thanks Enrico Il Dom 4 Apr 2021, 06:44 Mohammad Arshad <ars...@apache.org> ha scritto: > Greetings all, > As pointed out by Damien Diederen, there are many discrepancies in release > notes. Because of this RC0 is cancelled. > I will publish RC1 soon. > Thanks Damien for your valuable inputs. > Thanks Patric sir for your timely voting > > Thanks & Regards > Arshad > > > On Sat, Apr 3, 2021 at 4:55 PM Damien Diederen <ddiede...@apache.org> > wrote: > > > > > Hi Arshad, > > > > Generally looks good—but see my point about releases notes below. > > > > +1 (advisory): > > > > * Tarball contents match repository tag; > > > > * Verified checksums and signatures; > > > > * Built and smoke-tested on NixOS with a slightly adapted version of > > the Nix recipe; > > > > * Smoke-tested a standalone server with the (corresponding) Java, C > > and Perl clients, as well as the zkfuse contrib; > > > > * Smoke-tested a 3-ensemble with the (corresponding) Java client and > > SASL/GSSAPI. > > > > It seems that there were some errors in the bug tracker's "Fix > > Version/s" field which in turn caused the release notes to be slightly > > inconsistent: > > > > 1. ZOOKEEPER-3774, ZOOKEEPER-3798, ZOOKEEPER-3841 and ZOOKEEPER-3858 > > are mentioned, but seem to only be present in master; > > > > 2. ZOOKEEPER-3933 and ZOOKEEPER-3934 are mentioned, but these tickets > > were closed without any changes; > > > > 3. ZOOKEEPER-3931 is in 3.6.3, but not mentioned as the ticket has not > > been closed; > > > > 4. ZOOKEEPER-3957, ZOOKEEPER-3980 and ZOOKEEPER-3992 are in 3.6.3, but > > not mentioned as the tickets are only tagged with 3.7.0. > > > > The annoying bit, of course, is that releasenotes.md is on the release > > branch. Corrections should be applied there if another RC is published. > > I, for one, would be fine with only applying corrections to the website > > and in a subsequent commit if RC 0 is promoted to release status. > > > > Best, -D > > > > P.-S. — I have *not* tested under Ubuntu, nor have I used the staging > > repo. These are important points, but I figured most other testers > > would focus on them. Holler if that turns out not to be the case! > > > > > > > > Mohammad Arshad <ars...@apache.org> writes: > > > This is a bug fix release candidate for 3.6.3. It contains 51 fixes. > > > > > > The full release notes is available at: > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12348703 > > > > > > *** Please download, test and vote by Tuesday, April 6th 2021, 23:59 > > UTC+0. > > > *** > > > > > > Source and binary files: > > > https://people.apache.org/~arshad/zookeeper-3.6.3-candidate-0/ > > > > > > Maven staging repo: > > > > > > https://repository.apache.org/content/repositories/orgapachezookeeper-1068/ > > > > > > The release candidate tag in git to be voted upon: release-3.6.3-0 > > > https://github.com/apache/zookeeper/tree/release-3.6.3-0 > > > > > > ZooKeeper's KEYS file containing PGP keys we use to sign the release: > > > https://www.apache.org/dist/zookeeper/KEYS > > > > > > The staging version of the website is: > > > https://people.apache.org/~arshad/zookeeper-3.6.3-candidate-0/website/ > > > > > > Should we release this candidate? > > > > > > Thanks & Regards > > > Arshad > > >
