+1 (non-binding)

Checked on macOS: licenses, build and test passed, ran ZK and few standard
commands, signature.
Also built and run unit tests on ubuntu.

Thanks Arshad!

- Norbert

On Sat, Apr 10, 2021 at 10:34 AM Damien Diederen <ddiede...@apache.org>
wrote:

>
> Hi Arshad, all,
>
> LGTM!  +1 (advisory):
>
>   * Tarball contents match repository tag;
>
>   * Verified checksums and signatures;
>
>   * Built and smoke-tested on NixOS with a slightly adapted version of
>     the Nix recipe and test case;
>
>   * Smoke-tested a standalone server with the (corresponding) Java, C
>     and Perl clients, as well as the zkfuse contrib;
>
>   * Smoke-tested a 3-ensemble with the (corresponding) Java client and
>     SASL/GSSAPI.
>
> Sorry if I made you feel you had to go around with RC 0!  Oh well, at
> least we got some additional CVE fixes bundled in.
>
> Best, -D
>
> P.-S. — As with my previous review, I have *not* tested under Ubuntu nor
>   used the staging repo.  These are important points, but I figured most
>   other testers would focus on them.
>
>
>
> Mohammad Arshad <ars...@apache.org> writes:
> > This is a bug fix release candidate for 3.6.3. It fixes 52 issues,
> > including multiple CVE fixes.
> >
> > The full release notes is available at:
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801&version=12348703
> >
> > **** Please download, test and vote by Sunday, April 11th 2021, 23:59
> > UTC+0. ****
> >
> > Source and binary files:
> > https://people.apache.org/~arshad/zookeeper-3.6.3-candidate-2/
> >
> > Maven staging repo:
> >
> https://repository.apache.org/content/repositories/orgapachezookeeper-1071
> >
> > The release candidate tag in git to be voted upon: release-3.6.3-2
> > https://github.com/apache/zookeeper/tree/release-3.6.3-2
> >
> > ZooKeeper's KEYS file containing PGP keys we use to sign the release:
> > https://www.apache.org/dist/zookeeper/KEYS
> >
> > The staging version of the website is:
> > https://people.apache.org/~arshad/zookeeper-3.6.3-candidate-2/website/
> >
> > Should we release this candidate?
> >
> > Thanks & Regards
> > Arshad
>

Reply via email to