If that's your intention, yes the CI can allow that. I've pushed a v2
candidate branch of this series here with your review tags provided so far.
https://github.com/makubacki/edk2/tree/add_missing_ci_yaml_intel_fsp_pkgs_v2
This patch (v1 5/7) is removed from that branch and the change to
explicitly allow this is in the following commit on that branch:
https://github.com/makubacki/edk2/commit/b11dd1a4f59a62b90ed401b6b7cad889dd1e013f#diff-ba7b110a0ec2f7f8fabc973b327ddb98a7d65b6a00b544a609a56593e6b87be3R80-R86
If that looks good, let me know and I can send the v2 series on the list
after leaving v1 open for a bit longer to collect other feedback and
reviews.
Thanks,
Michael
On 9/6/2022 11:49 PM, Chiu, Chasel wrote:
Hi Michael,
In this case we intended to provide a single-small function in separate library
for platform customization so platforms do not have to override the whole main
library instance, and I think it is not valuable to create another H file to
hold this single small library function. Is it possible to support such
scenario in CI?
Thanks,
Chasel
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael
Kubacki
Sent: Tuesday, September 6, 2022 8:19 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel <chasel.c...@intel.com>; Desimone, Nathaniel L
<nathaniel.l.desim...@intel.com>; Zeng, Star <star.z...@intel.com>
Subject: [edk2-devel] [PATCH v1 5/7] IntelFsp2WrapperPkg.dec: Remove
duplicate LibraryClasses entry
From: Michael Kubacki <michael.kuba...@microsoft.com>
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4048
The last [LibraryClasses] entry for FspWrapperPlatformMultiPhaseLib points to
the same entry as FspWrapperMultiPhaseProcessLib.
FspWrapperPlatformMultiPhaseHandler() is the only function implemented in
FspWrapperPlatformMultiPhaseLibNull.c and it is only called (not implemented)
in PeiFspWrapperMultiPhaseProcessLib.c,
so I'd assume:
- Producing library: FspWrapperPlatformMultiPhaseLib
- Consuming library: FspWrapperMultiPhaseProcessLib
But, the API descriptions do not provide any descriptive information:
FspWrapperPlatformMultiPhaseHandler():
```
/**
FSP Wrapper Platform MultiPhase Handler
@param[in] FspHobListPtr - Pointer to FSP HobList (valid
after FSP-M completed)
@param[in] ComponentIndex - FSP Component which executing
MultiPhase initialization.
@param[in] PhaseIndex - Indicates current execution phase
of FSP MultiPhase initialization.
@retval EFI_STATUS Always return EFI_SUCCESS
**/
```
In any case, this removes the redundant header file entry so the Library Class
Check CI test can pass on the package.
Cc: Chasel Chiu <chasel.c...@intel.com>
Cc: Nate DeSimone <nathaniel.l.desim...@intel.com>
Cc: Star Zeng <star.z...@intel.com>
Signed-off-by: Michael Kubacki <michael.kuba...@microsoft.com>
---
IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec | 4 ----
1 file changed, 4 deletions(-)
diff --git a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec
b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec
index 95ada0f7a151..c3bbc5c45517 100644
--- a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec
+++ b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec
@@ -32,10 +32,6 @@ [LibraryClasses]
## @libraryclass Provide MultiPhase handling related functions.
FspWrapperMultiPhaseProcessLib|Include/Library/FspWrapperMultiPhaseProce
ssLib.h
- ## @libraryclass Provide MultiPhase platform actions related functions.
-
FspWrapperPlatformMultiPhaseLib|Include/Library/FspWrapperMultiPhaseProc
essLib.h
-
-
[Guids]
#
# GUID defined in package
--
2.28.0.windows.1
-=-=-=-=-=-=
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93319): https://edk2.groups.io/g/devel/message/93319
Mute This Topic: https://groups.io/mt/93518040/1777047
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [chasel.c...@intel.com]
-=-=-=-=-=-=
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93332): https://edk2.groups.io/g/devel/message/93332
Mute This Topic: https://groups.io/mt/93518040/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
