[edk2-devel] [PATCH 15/18] SourceLevelDebugPkg: Update code to be more C11 compliant by using __func__

[Rebecca Cran]

__FUNCTION__ is a pre-standard extension that gcc and Visual C++ among
others support, while __func__ was standardized in C99.

Since it's more standard, replace __FUNCTION__ with __func__ throughout
SourceLevelDebugPkg.

Visual Studio versions before VS 2015 don't support __func__ and so
will fail to compile. A workaround is to define __func__ as
__FUNCTION__ :

  #define __func__ __FUNCTION__

Signed-off-by: Rebecca Cran <rebe...@bsdio.com>
---
 
SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunicationLibUsb3Dxe.c
 | 4 ++--
 
SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunicationLibUsb3Pei.c
 | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git 
a/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunicationLibUsb3Dxe.c
 
b/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunicationLibUsb3Dxe.c
index 4490526273c9..d37fb991f1f2 100644
--- 
a/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunicationLibUsb3Dxe.c
+++ 
b/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunicationLibUsb3Dxe.c
@@ -186,7 +186,7 @@ Usb3DxeSmmReadyToLockNotify (
 {
   USB3_DEBUG_PORT_HANDLE  *Instance;
 
-  DEBUG ((DEBUG_INFO, "%a()\n", __FUNCTION__));
+  DEBUG ((DEBUG_INFO, "%a()\n", __func__));
 
   Instance = GetUsb3DebugPortInstance ();
   ASSERT (Instance != NULL);
@@ -290,7 +290,7 @@ Usb3PciIoNotify (
         //
         // Found the PciIo for USB3 debug port.
         //
-        DEBUG ((DEBUG_INFO, "%a()\n", __FUNCTION__));
+        DEBUG ((DEBUG_INFO, "%a()\n", __func__));
         if (Usb3GetIoMmu () != NULL) {
           Instance = GetUsb3DebugPortInstance ();
           ASSERT (Instance != NULL);
diff --git 
a/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunicationLibUsb3Pei.c
 
b/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunicationLibUsb3Pei.c
index 15842a317ef0..aa04442918d2 100644
--- 
a/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunicationLibUsb3Pei.c
+++ 
b/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommunicationLibUsb3Pei.c
@@ -35,7 +35,7 @@ Usb3IoMmuPpiNotify (
 {
   USB3_DEBUG_PORT_HANDLE  *Instance;
 
-  DEBUG ((DEBUG_INFO, "%a()\n", __FUNCTION__));
+  DEBUG ((DEBUG_INFO, "%a()\n", __func__));
 
   Instance = GetUsb3DebugPortInstance ();
   ASSERT (Instance != NULL);
-- 
2.34.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102645): https://edk2.groups.io/g/devel/message/102645
Mute This Topic: https://groups.io/mt/98115253/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-