[AMD Official Use Only - General]
Hi Rebecca,
I can only give you reviewed-by for RedfishPlatformHostInterfaceLib.c.
Reviewed-by: Abner Chang <abner.ch...@amd.com>
> -----Original Message-----
> From: Rebecca Cran <rebe...@bsdio.com>
> Sent: Friday, April 7, 2023 6:23 AM
> To: devel@edk2.groups.io; Liming Gao <gaolim...@byosoft.com.cn>;
> Michael D Kinney <michael.d.kin...@intel.com>; Guomin Jiang
> <guomin.ji...@intel.com>; Wei6 Xu <wei6...@intel.com>; Guo Dong
> <guo.d...@intel.com>; Ray Ni <ray...@intel.com>; Sean Rhodes
> <sean@starlabs.systems>; James Lu <james...@intel.com>; Gua Guo
> <gua....@intel.com>; Andrew Fish <af...@apple.com>; Hao A Wu
> <hao.a...@intel.com>; Maciej Rabeda <maciej.rab...@linux.intel.com>;
> Siyuan Fu <siyuan...@intel.com>; Jiewen Yao <jiewen....@intel.com>; Jian
> J Wang <jian.j.w...@intel.com>; Xiaoyu Lu <xiaoyu1...@intel.com>; Ard
> Biesheuvel <ardb+tianoc...@kernel.org>; Sami Mujawar
> <sami.muja...@arm.com>; Supreeth Venkatesh
> <supreeth.venkat...@arm.com>; Michael Kubacki
> <mikub...@linux.microsoft.com>; Nate DeSimone
> <nathaniel.l.desim...@intel.com>; Sean Brogan
> <sean.bro...@microsoft.com>
> Cc: Rebecca Cran <rebe...@bsdio.com>; Leif Lindholm
> <quic_llind...@quicinc.com>; Chang, Abner <abner.ch...@amd.com>;
> Nickle Wang <nick...@nvidia.com>; Igor Kulchytskyy <ig...@ami.com>;
> Daniel Schaefer <g...@danielschaefer.me>; Min Xu <min.m...@intel.com>;
> Jordan Justen <jordan.l.jus...@intel.com>; Gerd Hoffmann
> <kra...@redhat.com>; Peter Grehan <gre...@freebsd.org>; Erdem Aktas
> <erdemak...@google.com>; James Bottomley <j...@linux.ibm.com>;
> Lendacky, Thomas <thomas.lenda...@amd.com>; Roth, Michael
> <michael.r...@amd.com>; Sunil V L <suni...@ventanamicro.com>; Andrei
> Warkentin <andrei.warken...@intel.com>
> Subject: [PATCH 16/18] EmulatorPkg: Update code to be more C11 compliant
> by using __func__
>
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
>
>
> __FUNCTION__ is a pre-standard extension that gcc and Visual C++ among
> others support, while __func__ was standardized in C99.
>
> Since it's more standard, replace __FUNCTION__ with __func__ throughout
> EmulatorPkg.
>
> Visual Studio versions before VS 2015 don't support __func__ and so will fail
> to compile. A workaround is to define __func__ as __FUNCTION__ :
>
> #define __func__ __FUNCTION__
>
> Signed-off-by: Rebecca Cran <rebe...@bsdio.com>
> ---
>
> EmulatorPkg/Library/RedfishPlatformHostInterfaceLib/RedfishPlatformHostI
> nterfaceLib.c | 2 +-
> EmulatorPkg/Win/Host/WinPacketFilter.c
> | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git
> a/EmulatorPkg/Library/RedfishPlatformHostInterfaceLib/RedfishPlatformHo
> stInterfaceLib.c
> b/EmulatorPkg/Library/RedfishPlatformHostInterfaceLib/RedfishPlatformHo
> stInterfaceLib.c
> index 4361bd4170e3..4332caa71016 100644
> ---
> a/EmulatorPkg/Library/RedfishPlatformHostInterfaceLib/RedfishPlatformHo
> stInterfaceLib.c
> +++ b/EmulatorPkg/Library/RedfishPlatformHostInterfaceLib/RedfishPlatfor
> +++ mHostInterfaceLib.c
> @@ -538,7 +538,7 @@ RedfishPlatformHostInterfaceConstructor (
> EFI_STATUS Status;
>
> Status = GetRedfishRecordFromVariable (&mRedfishOverIpProtocolData,
> &mRedfishProtocolDataSize);
> - DEBUG ((DEBUG_INFO, "%a: GetRedfishRecordFromVariable() - %r\n",
> __FUNCTION__, Status));
> + DEBUG ((DEBUG_INFO, "%a: GetRedfishRecordFromVariable() - %r\n",
> + __func__, Status));
> if (!EFI_ERROR (Status)) {
> DumpRedfishIpProtocolData (mRedfishOverIpProtocolData,
> mRedfishProtocolDataSize);
> }
> diff --git a/EmulatorPkg/Win/Host/WinPacketFilter.c
> b/EmulatorPkg/Win/Host/WinPacketFilter.c
> index 21859897c85f..a71c7e8c131b 100644
> --- a/EmulatorPkg/Win/Host/WinPacketFilter.c
> +++ b/EmulatorPkg/Win/Host/WinPacketFilter.c
> @@ -966,7 +966,7 @@ WintNtInitializeNetUtilityData (
> goto ErrorReturn;
> }
>
> - DEBUG ((DEBUG_INFO, "%a, total %d interface(s) found\n",
> __FUNCTION__, InterfaceCount));
> + DEBUG ((DEBUG_INFO, "%a, total %d interface(s) found\n", __func__,
> + InterfaceCount));
> //
> // Active interface index is set to first interface if given instance does
> // not exist.
> --
> 2.34.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102675): https://edk2.groups.io/g/devel/message/102675
Mute This Topic: https://groups.io/mt/98115254/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
