Reviewed-by: Ray Ni <ray...@intel.com>
> -----Original Message-----
> From: Rebecca Cran <rebe...@bsdio.com>
> Sent: Friday, April 7, 2023 6:23 AM
> To: devel@edk2.groups.io; Gao, Liming <gaolim...@byosoft.com.cn>;
> Kinney, Michael D <michael.d.kin...@intel.com>; Jiang, Guomin
> <guomin.ji...@intel.com>; Xu, Wei6 <wei6...@intel.com>; Dong, Guo
> <guo.d...@intel.com>; Ni, Ray <ray...@intel.com>; Rhodes, Sean
> <sean@starlabs.systems>; Lu, James <james...@intel.com>; Guo, Gua
> <gua....@intel.com>; Andrew Fish <af...@apple.com>; Wu, Hao A
> <hao.a...@intel.com>; Maciej Rabeda <maciej.rab...@linux.intel.com>;
> Siyuan Fu <siyuan...@intel.com>; Yao, Jiewen <jiewen....@intel.com>;
> Wang, Jian J <jian.j.w...@intel.com>; Lu, Xiaoyu1 <xiaoyu1...@intel.com>;
> Ard Biesheuvel <ardb+tianoc...@kernel.org>; Sami Mujawar
> <sami.muja...@arm.com>; Supreeth Venkatesh
> <supreeth.venkat...@arm.com>; Michael Kubacki
> <mikub...@linux.microsoft.com>; Desimone, Nathaniel L
> <nathaniel.l.desim...@intel.com>; Sean Brogan
> <sean.bro...@microsoft.com>
> Cc: Rebecca Cran <rebe...@bsdio.com>; Leif Lindholm
> <quic_llind...@quicinc.com>; Abner Chang <abner.ch...@amd.com>;
> Nickle Wang <nick...@nvidia.com>; Igor Kulchytskyy <ig...@ami.com>;
> Daniel Schaefer <g...@danielschaefer.me>; Xu, Min M
> <min.m...@intel.com>; Justen, Jordan L <jordan.l.jus...@intel.com>; Gerd
> Hoffmann <kra...@redhat.com>; Peter Grehan <gre...@freebsd.org>;
> Aktas, Erdem <erdemak...@google.com>; James Bottomley
> <j...@linux.ibm.com>; Tom Lendacky <thomas.lenda...@amd.com>;
> Michael Roth <michael.r...@amd.com>; Sunil V L
> <suni...@ventanamicro.com>; Warkentin, Andrei
> <andrei.warken...@intel.com>
> Subject: [PATCH 15/18] SourceLevelDebugPkg: Update code to be more C11
> compliant by using __func__
>
> __FUNCTION__ is a pre-standard extension that gcc and Visual C++ among
> others support, while __func__ was standardized in C99.
>
> Since it's more standard, replace __FUNCTION__ with __func__ throughout
> SourceLevelDebugPkg.
>
> Visual Studio versions before VS 2015 don't support __func__ and so
> will fail to compile. A workaround is to define __func__ as
> __FUNCTION__ :
>
> #define __func__ __FUNCTION__
>
> Signed-off-by: Rebecca Cran <rebe...@bsdio.com>
> ---
>
> SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommu
> nicationLibUsb3Dxe.c | 4 ++--
>
> SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommu
> nicationLibUsb3Pei.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git
> a/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCom
> municationLibUsb3Dxe.c
> b/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCom
> municationLibUsb3Dxe.c
> index 4490526273c9..d37fb991f1f2 100644
> ---
> a/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCom
> municationLibUsb3Dxe.c
> +++
> b/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCom
> municationLibUsb3Dxe.c
> @@ -186,7 +186,7 @@ Usb3DxeSmmReadyToLockNotify (
> {
> USB3_DEBUG_PORT_HANDLE *Instance;
>
> - DEBUG ((DEBUG_INFO, "%a()\n", __FUNCTION__));
> + DEBUG ((DEBUG_INFO, "%a()\n", __func__));
>
> Instance = GetUsb3DebugPortInstance ();
> ASSERT (Instance != NULL);
> @@ -290,7 +290,7 @@ Usb3PciIoNotify (
> //
> // Found the PciIo for USB3 debug port.
> //
> - DEBUG ((DEBUG_INFO, "%a()\n", __FUNCTION__));
> + DEBUG ((DEBUG_INFO, "%a()\n", __func__));
> if (Usb3GetIoMmu () != NULL) {
> Instance = GetUsb3DebugPortInstance ();
> ASSERT (Instance != NULL);
> diff --git
> a/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCom
> municationLibUsb3Pei.c
> b/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCom
> municationLibUsb3Pei.c
> index 15842a317ef0..aa04442918d2 100644
> ---
> a/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCom
> municationLibUsb3Pei.c
> +++
> b/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCom
> municationLibUsb3Pei.c
> @@ -35,7 +35,7 @@ Usb3IoMmuPpiNotify (
> {
> USB3_DEBUG_PORT_HANDLE *Instance;
>
> - DEBUG ((DEBUG_INFO, "%a()\n", __FUNCTION__));
> + DEBUG ((DEBUG_INFO, "%a()\n", __func__));
>
> Instance = GetUsb3DebugPortInstance ();
> ASSERT (Instance != NULL);
> --
> 2.34.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102660): https://edk2.groups.io/g/devel/message/102660
Mute This Topic: https://groups.io/mt/98115253/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe:
https://edk2.groups.io/g/devel/leave/9847357/21656/1706620634/xyzzy
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
