On Fri, Jun 10, 2022 at 01:49:50PM +0200, Zbigniew Jędrzejewski-Szmek wrote: > On Thu, Jun 09, 2022 at 08:53:01PM +0200, Petr Menšík wrote: > > On 09. 06. 22 19:31, Zbigniew Jędrzejewski-Szmek wrote: > > > I reviewed your pull request > > > https://github.com/systemd/systemd/pull/21317. > > > I know you are trying to move things forward, but at the same time, > > > you're not really responding to feedback. Despite two versions being > > > pushed > > > in the meantime, my re-review was to a large part a repeat of what I > > > posted > > > in January. I said that the approach looks promising, but if you want the > > > patches to be merged, they need to be adjusted to be acceptable for > > > upstream. > > > > > > Zbyszek > > > > Funny. I have created prerequisite MR #21257 [1], which had not received any > > attention in months. It contains very simple change and I hope no > > controversy. Yet it has stayed like that for months. If not even that change > > were accepted, then work on MR #21317 would be a waste of my time. From > > Lennart's comments I got an impression similar change is unwanted. You > > haven't made a single comment after his comments it is still worth to > > proceed. I don't know if you vote, but I got an impression Lennart has to > > agree or don't be involved. Was that wrong? > > > > Petr > > > > 1. https://github.com/systemd/systemd/pull/21257 > > Pull requests occasionally get forgotten. A comment with a ping usually helps.
https://github.com/systemd/systemd/pull/23699 Zbyszek _______________________________________________ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
