On 06/18/2014 02:16 PM, Adam Jackson wrote:
If I may vent for a moment, I'd like to point out exactly how spurious
the blocks usage was (and, implicitly, troll for code review):
http://pkgs.fedoraproject.org/cgit/hfsplus-tools.git/plain/hfsplus-tools-no-blocks.patch
That's right kids, the C89 version is less code even _before_ you
count the actual Blocks runtime.
I should know better than start an argument about programming with you,
but isn't your patch leaking memory? I don't know how often hfsplus
tools allocate ctx->preMessage but just overwriting the pointer seems
off. At least a comment, maybe?
- if (bp)
- ctx->postMessage = (fsckBlock_t)Block_copy(bp);
+ /* possible memory leak: unlinking old postMessage */
+ ctx->postMessage = bp;
--
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct
