On Wed, Feb 18, 2026 at 01:05:59PM +0100, Andrea Bolognani via Devel wrote: > Provide a new set of command line flags named after varstore, > mirroring the ones that already exist for NVRAM. Users will > not need to worry about whether the guest uses one or the > other, since either version will seamlessly apply to both > scenarios, meaning among other things that existing scripts > will continue working as expected.
I'm more inclined to just document that '--reset-nvram' applies to all cases and not introduce new args that are just a synonym. Users don't really need to even know that the JSON vars aren't using NVRAM. Adding 2 args for the same thing, suggests to users that they first need to look at the guest XML to determine which arg to use for a given guest, which is rather unproductive / unhelpful. > > Signed-off-by: Andrea Bolognani <[email protected]> > --- > docs/manpages/virsh.rst | 44 ++++++++++++++++++++------------- > tools/virsh-domain.c | 55 ++++++++++++++++++++++++++++++++--------- > tools/virsh-snapshot.c | 9 +++++-- > 3 files changed, 78 insertions(+), 30 deletions(-) With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|
