On Mon, Feb 23, 2026 at 11:31:15AM -0500, Andrea Bolognani wrote:
> On Mon, Feb 23, 2026 at 02:26:25PM +0000, Daniel P. Berrangé wrote:
> > On Wed, Feb 18, 2026 at 01:05:52PM +0100, Andrea Bolognani via Devel wrote:
> > > Now that everything else is in place, we can finally add the
> > > firmware descriptors for the edk2 builds that use the uefi-vars
> > > QEMU device.
> > >
> [...]
> > >
> > > https://issues.redhat.com/browse/RHEL-82645
> >
> > That's a ticket against libvirt in RHEL...
> >
> > > DONOTMERGE: The firmware descriptors have not been added to the
> > >             Fedora edk2 package yet.
> >
> > but this talks about EDK2 in Fedora. For that the link should
> > be
> >
> > https://src.fedoraproject.org/rpms/edk2/pull-request/15
> >
> > which was both opened and merged today.  I've not checked if
> > that PR matches what you've added here, so will let you
> > re-evaluate that before reviewing this patch.
> 
> There are changes between what I suggested here and what was
> ultimately merged into Fedora, but they're not semantically
> meaningful: the descriptors have slightly different names but the
> ordering remains the same, the paths to the firmware files themselves
> are also slightly different. I have already imported the actual
> descriptors file locally.

Ok on that basis

Reviewed-by: Daniel P. Berrangé <[email protected]>

With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|

Reply via email to