On Mon, Feb 23, 2026 at 04:54:42PM +0000, Daniel P. Berrangé wrote: > On Mon, Feb 23, 2026 at 11:41:14AM -0500, Andrea Bolognani wrote: > > On Mon, Feb 23, 2026 at 02:46:31PM +0000, Daniel P. Berrangé wrote: > > > Adding 2 args for the same thing, suggests to users that they first > > > need to look at the guest XML to determine which arg to use for a > > > given guest, which is rather unproductive / unhelpful. > > > > That's true to some extent, but so is the opposite scenario: the user > > has already looked at the XML, knows what element is used there, and > > now has to figure out whether the virsh option matches the name of > > the element or is... The other one. > > I don't see that as a real world problem as "--reset-nvram" is > trivially discoverable with the updated docs string that mentions > its effect on 'varstore'. I just don't see a need to change anything > here except the docs.
I'm still convinced that it will prove to be less usable in the long run, but then again many of our existing APIs suffer from similar quirks already, so I'll do what you ask and update the documentation only :) -- Andrea Bolognani / Red Hat / Virtualization
