Hi, 2016-08-19 17:25 GMT+02:00 Kaspar Schleiser <kas...@schleiser.de>:
> Hey, > > On 08/19/2016 05:15 PM, Oleg Hahm wrote: > > Hence, I would propose to somehow reference the addressed > > comment in the commit message. What do you think? > > That would rule out --fixup commits (and thus automatic rebasing). "git > commit --squash" allows adding to the commit message, but the commit > subject stays the same, so in order to improve things, one would have to > unfold the whole message in git's PR overview > Not necessarily. I would put such links to comments in the commit body anyway and that is ignored by --autosquash. > (+1 in general...) > +1 from my side too. 2016-08-19 17:39 GMT+02:00 Oleg Hahm <oliver.h...@inria.fr>: > Actually, I've never found a big advantage in automatic rebasing. If you > specify both, the addressed comment and the corresponding commit in the > commit > message, interactive rebasing can be done in no time. > Well you still have to read and compare every single commit, which --autosquash just takes a way. So you still need way more time. ;-) Regards, Martine
_______________________________________________ devel mailing list devel@riot-os.org https://lists.riot-os.org/mailman/listinfo/devel
