On 07/04/2022 14:51, gabriel.moy...@dlr.de wrote:
In general, the patch set lacks test cases.
I was thinking that the next step could be to add a generic device which is 
required to use the API (a file descriptor is needed). This is
something that wanted to ask in the mailing list first. When this device is 
added, also the test cases can be. Furthermore I wanted to
split the submitted changes in order to make a review easier.

A file descriptor should be optional. It should be possible to add a PPS driver 
just using struct pps_state.
The struct pps_state type is used only internally. In order to be able to use 
the API a file descriptor is required (API functions start with time_pps_*()).
The "generic device" I have in mind will have an object of struct pps_state.

A PPS device driver needs access to the _KERNEL API defined by <sys/timepps.h>. It should not be required to use a file descriptor.

The user space time_pps_*() API is an optional component.

--
embedded brains GmbH
Herr Sebastian HUBER
Dornierstr. 4
82178 Puchheim
Germany
email: sebastian.hu...@embedded-brains.de
phone: +49-89-18 94 741 - 16
fax:   +49-89-18 94 741 - 08

Registergericht: Amtsgericht München
Registernummer: HRB 157899
Vertretungsberechtigte Geschäftsführer: Peter Rasmussen, Thomas Dörfler
Unsere Datenschutzerklärung finden Sie hier:
https://embedded-brains.de/datenschutzerklaerung/
_______________________________________________
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Reply via email to