richardelling commented on this pull request.
> @@ -55,11 +55,10 @@ extern boolean_t zfs_free_leak_on_eio; #define ZFS_DEBUG_DNODE_VERIFY (1 << 2) #define ZFS_DEBUG_SNAPNAMES (1 << 3) #define ZFS_DEBUG_MODIFY (1 << 4) -#define ZFS_DEBUG_SPA (1 << 5) I'd rather not remove this for the selfishly simple case that existing debug scripts outside of the OpenZFS tree have documented these and exposed them to people. Rather than removal, can we just add a /* deprecated */ comment? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/580#pullrequestreview-101312084 ------------------------------------------ openzfs: openzfs-developer Permalink: https://openzfs.topicbox.com/groups/developer/discussions/Tc900752b49c91015-M75ec336cca9764b0da7e65d3 Delivery options: https://openzfs.topicbox.com/groups
