ahrens commented on this pull request.
> @@ -55,11 +55,10 @@ extern boolean_t zfs_free_leak_on_eio; #define ZFS_DEBUG_DNODE_VERIFY (1 << 2) #define ZFS_DEBUG_SNAPNAMES (1 << 3) #define ZFS_DEBUG_MODIFY (1 << 4) -#define ZFS_DEBUG_SPA (1 << 5) While I see this as a pretty deep internal detail that folks shouldn't be relying on, you could also argue that these should really be separate boolean_t tunables. If we had done that, retiring one of them might break your script but it wouldn't do something surprising. Given that there are plenty of bits, how about we remove `ZFS_DEBUG_SPA` but leave a comment saying `/* 1<<5 was previously used, try not to reuse */`. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/580#discussion_r172380168 ------------------------------------------ openzfs: openzfs-developer Permalink: https://openzfs.topicbox.com/groups/developer/discussions/Tc900752b49c91015-M7f6c2d8bd68dba0c4c87fe36 Delivery options: https://openzfs.topicbox.com/groups
