On Tue, May 8, 2012 at 4:22 PM, Rohan McGovern <rohan.mcgov...@nokia.com> wrote: > Girish Ramakrishnan said: >> Hi, >> >> On Tue, May 8, 2012 at 3:07 AM, Girish Ramakrishnan >> <gir...@forwardbias.in> wrote: >> > The change landed. For some reason, the ci is failing compile in all >> > other modules. Works locally with shadow builds but not on CI. I am on >> > it. >> > >> >> Fix is integrating: https://codereview.qt-project.org/#change,25570. >> Sorry for blocking the CI. >> > > Ideally this would have been caught by the reverse dependency qtdeclarative > test in qtbase's CI, but apparently the issue only affected shadow builds, > which weren't covered. >
This should ideally have been caught by my own build testing. I only tested shadow builds using -developer-build in which "make install" is not required. > We'll add a shadow build revdep-qtdeclarative config to prevent similar > issues in the future. Sounds good to me. Girish _______________________________________________ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development