Just looking at the topic of that thread, I suggest to name it: QVersionNubmer. QVersion may suggest some more, like description of the version or provide an info about different set of features. ________________________________________ From: development-bounces+jaroslaw.kobus=digia....@qt-project.org [development-bounces+jaroslaw.kobus=digia....@qt-project.org] on behalf of Keith Gardner [kreios4...@gmail.com] Sent: 10 July 2014 14:53 To: Olivier Goffart Cc: <development@qt-project.org> Subject: Re: [Development] Adding support for version number comparisons
On Thu, Jul 10, 2014 at 7:31 AM, Olivier Goffart <oliv...@woboq.com<mailto:oliv...@woboq.com>> wrote: On Monday 02 June 2014 13:24:55 Richard Moore wrote: > On 2 June 2014 13:12, Keith Gardner > <kreios4...@gmail.com<mailto:kreios4...@gmail.com>> wrote: > > On Mon, Jun 2, 2014 at 2:36 AM, Simon Hausmann > > <simon.hausm...@digia.com<mailto:simon.hausm...@digia.com>> > > > > wrote: > >> I suggest a name that is more centric towards the _function_ of the > >> class, > >> comparison of different software versions. > > > > QVersionInformation was also proposed as a name in the code review. I > > don't have a problem with changing the name other than it is really long > > for a simple class. > > How about QVersionComparator? How about qVersionCompare(const QString&, const QString&)? Yes, that's a function. Is there really the need for a class to hold just a version string? And there could be an overload with a SuffixComparator. (or is qCompareVersion an even better name?) Currently, the QVersion::compare has an overload to pass a functor that performs the suffix comparison. Are you suggesting having a "default" in the operators that can be overwritten? _______________________________________________ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
