I comitted the changes, so the normal ByteCounter now has a start method.
I also fixed up the cli InsertClient so that it uses Paul's
CounterFilterInputStream. BTW, Paul, the counters in FGUI (the AWT one) are
still not drawing right for me. Sometimes I see a corner of them and then the
disappear, sometimes I don't see anything at all. (I think you have to remember
that the conduit runs async, so if you want to call finished on the counter, it
has to be done in a thread that does wait() on the inputstream (Conduit will do
notifyAll() on it)).
BTW: FGUI, FGUI, GUI, InsertClient what the fuck for names are these, have we
zero creativity?
On Sat, 15 Apr 2000, Oskar Sandberg wrote:
> On Sat, 15 Apr 2000, Jebu Ittiachen wrote:
> > I'm putting in the Swing based GUIin a seperate package
> > Freenet.contrib.SwingFree and i was looking on maximum integration with
> > FGUI, however one small place where the things mismatch is the counter,
> > SimpleClient uses ProgressBar as the counter, would it be possible to have
> > it based on an interface say like
> >
> > public interface GUIByteCounter extends ByteCounter{
> > public void start(long val,String key);
> > }
> >
> > in Freenet.support and have the counter in SimpleClient shifted to
> > GUIByteCounter from ProgressBar??
>
> Is there any reason not the just add the start() method to the regular
> ByteCounter interface? The only other counter is the DotCounter of CLI
> clients,
> but it would be easy to add a start() to that.
>
> I don't believe in all the ptttuii about good design principles and not
> changing Interfaces. They are meant for smarter programmers then me who get
> things right the first time.
>
> >
> >
> > jebu
> >
> > ----- Original Message -----
> > From: "Paul Kappler" <kapplepc at mac.com>
> > To: <freenet-dev at lists.sourceforge.net>
> > Sent: Friday, April 14, 2000 9:56 PM
> > Subject: [Freenet-dev] FGUI changes
> >
> >
> > > I have just integrated some changes to FGUI I was working on earlier
> > today.
> > > They are intended to fix a inconsistency between the progress bar and what
> > > is really going on. I have added two classes to /Freenet/support to make
> > > this happen: CounterFilterInputStream and CounterFilterOutputStream.
> > >
> > > The change also eliminates the need for a PipedXXXStreams and SpiltOutput
> > > streams for showing progress. I think this is for the better and the same
> > > should be done in the command line client. Opinions?
> > >
> > > Paul Kappler
> > >
> > >
> > > _______________________________________________
> > > Freenet-dev mailing list
> > > Freenet-dev at lists.sourceforge.net
> > > http://lists.sourceforge.net/mailman/listinfo/freenet-dev
> > >
> >
> > _____________________________________________
> > NetZero - Defenders of the Free World
> > Click here for FREE Internet Access and Email
> > http://www.netzero.net/download/index.html
> >
> > _______________________________________________
> > Freenet-dev mailing list
> > Freenet-dev at lists.sourceforge.net
> > http://lists.sourceforge.net/mailman/listinfo/freenet-dev
> --
>
> Oskar Sandberg
>
> md98-osa at nada.kth.se
>
> #!/bin/perl -sp0777i<X+d*lMLa^*lN%0]dsXx++lMlN/dsM0<j]dsj
> $/=unpack('H*',$_);$_=`echo 16dio\U$k"SK$/SM$n\EsN0p[lN*1
> lK[d2%Sa2/d0$^Ixp"|dc`;s/\W//g;$_=pack('H*',/((..)*)$/)
>
> _______________________________________________
> Freenet-dev mailing list
> Freenet-dev at lists.sourceforge.net
> http://lists.sourceforge.net/mailman/listinfo/freenet-dev
--
Oskar Sandberg
md98-osa at nada.kth.se
#!/bin/perl -sp0777i<X+d*lMLa^*lN%0]dsXx++lMlN/dsM0<j]dsj
$/=unpack('H*',$_);$_=`echo 16dio\U$k"SK$/SM$n\EsN0p[lN*1
lK[d2%Sa2/d0$^Ixp"|dc`;s/\W//g;$_=pack('H*',/((..)*)$/)
_______________________________________________
Freenet-dev mailing list
Freenet-dev at lists.sourceforge.net
http://lists.sourceforge.net/mailman/listinfo/freenet-dev
