The GitHub verify job for releng/builder is not working: https://git.opendaylight.org/gerrit/c/releng/builder/+/109953
The verify job adds GitHub as the remote: https://github.com/opendaylight/releng-builder/actions/runs/7649916439/job/20845142225 Initialized empty Git repository in > /home/runner/work/releng-builder/releng-builder/.git/ > /usr/bin/git remote add origin > https://github.com/opendaylight/releng-builder so it fails to fetch the change: git fetch origin refs/changes/53/109953/2 && git checkout FETCH_HEAD > shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0} > env: > OS_CLOUD: vex > PACKER_VERSION: 1.9.1 > fatal: couldn't find remote ref refs/changes/53/109953/2 And this is blocking submission so I had to override it by removing the '-1'. Thanks, Sangwook On Wed, Jan 24, 2024 at 6:03 PM Andrew Grimberg < agrimb...@linuxfoundation.org> wrote: > Greetings Robert, > > On 1/24/24 07:47, Robert Varga wrote: > > On 07/11/2023 15.45, Andrew Grimberg wrote: > >> Greetings folks, > > > > Hello Andy, > > > >> TLDR; Changes now require 2 Verify+1 votes to be submittable. One of > >> the votes must come from the 'ODL Required GHA' user. > > > > okay, so here is a real-life problem: why doesn't the GHA action trigger > > for > https://urldefense.proofpoint.com/v2/url?u=https-3A__git.opendaylight.org_gerrit_c_aaa_-2B_109969&d=DwIGaQ&c=udBTRvFvXC5Dhqg7UHpJlPps3mZ3LRxpb6__0PomBTQ&r=tFlYQtdB5h1Aic2Ti7Ncev9qFTcOZoMgJ6CVN_sDUdU&m=SBj2vQWfiDQ7Qsm3GE2WKwCiQRkMoZxpu9M3LyhR-P2ASr6aA8m_G6oKYt4dSsHd&s=tHsPLnG5gQpX7Kw1cCv9JTBStAdfYHwTZpwbEkCQ01Q&e= > and how can I fix > > this? > > Anil was showing me this today, it wasn't (currently is) submitable due > to the GHA verify job not running on the change. After some exploration > we are finding that this is due to the GHA verify job not existing on > the branch, and since it's failing it's not triggering the required job > which is... required. We've got a temporary work around in place for > this and Anil understands the issue. I've also raised a bug [0] > specifically to handle this sort of problem correctly in the future. > > > Also, what is preventing > > > https://urldefense.proofpoint.com/v2/url?u=https-3A__git.opendaylight.org_gerrit_c_releng_builder_-2B_106213&d=DwIGaQ&c=udBTRvFvXC5Dhqg7UHpJlPps3mZ3LRxpb6__0PomBTQ&r=tFlYQtdB5h1Aic2Ti7Ncev9qFTcOZoMgJ6CVN_sDUdU&m=SBj2vQWfiDQ7Qsm3GE2WKwCiQRkMoZxpu9M3LyhR-P2ASr6aA8m_G6oKYt4dSsHd&s=auxVOu-Dn7aqNtOPz6fI8pkS3I3R93B6wkJabzYQnP8&e= > from being > > submitted? > > If you had looked at the submit requirements on the change you should > have noticed that the Code-Review was not being met. Hovering over the > Code-Review you'll see the conditions that need to be met. You were not > meeting them because the conditions state that a non-uploader must give > a +2 and looking at the owner and uploader I see that while Luis is the > owner of the change, the current change was uploaded by you. Therefore > your +2 of the change is not being counted by the system. The > releng/builder project has always had a Non-Author-Code-Review (NACR) > block given how the project operates. The new submit rules system makes > NACR a little bit more stringent in that an uploader is also considered > an author and therefore it blocks consideration of the votes. > > Since I still have +2 rights, I've gone ahead and reviewed and submitted > the change for you. > > -Andy- > > [0] > https://urldefense.proofpoint.com/v2/url?u=https-3A__jira.linuxfoundation.org_browse_RELENG-2D5100&d=DwIGaQ&c=udBTRvFvXC5Dhqg7UHpJlPps3mZ3LRxpb6__0PomBTQ&r=tFlYQtdB5h1Aic2Ti7Ncev9qFTcOZoMgJ6CVN_sDUdU&m=SBj2vQWfiDQ7Qsm3GE2WKwCiQRkMoZxpu9M3LyhR-P2ASr6aA8m_G6oKYt4dSsHd&s=wawPR05nRkwKR1utXnzoJJKQ7wb-N7hiHK5yDK2dZXA&e= > > -- > Andrew J Grimberg > Manager, Release Engineering > The Linux Foundation > > NOTICE: The Linux Foundation supports their employees with flexible work > hours. If you recieve mail from me outside of standard business hours > please be aware that I do not expect a response until the next standard > business day. > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#9068): https://lists.opendaylight.org/g/Discuss/message/9068 Mute This Topic: https://lists.opendaylight.org/mt/103948473/21656 Group Owner: discuss+ow...@lists.opendaylight.org Unsubscribe: https://lists.opendaylight.org/g/Discuss/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
