Right, but it makes me think that if this has come up before its not a minor feature request. The fact that huge numbers of well known sites are using email based authentication suggests its time for the 4 lines of code to be added to contrib/auth. Files in contrib are not written in stone.
I still have not heard a good enough reason not to add the code. Reasons why an alternate backend or view is not good: 1. Doing it in a view would bypass the auth system entirely, bad use of framework, poor re-use. 2. Adding a back end would introduce lots of code maintenance on the trunk, not optimal insertion point. 3. Maintaining my own back end, means others are doing the same, again poor re-use. Reasons why it is good: 1. Proven demand for feature (see previous tickets and threads). 2. No risk to existing functionality. 3. Very little additional code to maintain/debug. 4. Intuitive place to put this functionality is authentication. 5. Function is called authenticate, not authenticate_by_username_only. I understand the resistance but you've got demand, you've got a willing developer, and you've got a clean fix that significantly improves the adaptability of the framework. What better reason would you need? -Paul On Wed, Jul 2, 2008 at 9:30 AM, Waylan Limberg <[EMAIL PROTECTED]> wrote: > > Paul, > > I believe this issue has been brought up in various ways before. I'd > suggest searching the list archives and old closed tickets. You'll > likely find your answer there. > > More generally, there is already a mechanism in place to override the > default behavior and implement your own (building your own auth > backend), so I suspect the core devs would prefer that you do that > rather than build everyones minor feature request into the core. > Actually, I believe there are at least a few existing solutions out > there. A search should turn up a few gems for you. > > On Wed, Jul 2, 2008 at 11:48 AM, Paul Kenjora <[EMAIL PROTECTED]> wrote: > > I've been using Django for a while and recently started contributing to > the > > trunk. Previously I ran my own branch but sooner or later that gets > > tiresome. So I created a ticket the other day: > > > > http://code.djangoproject.com/ticket/7591 > > > > The ticket suggests a patch to contrib/auth that will allow authenticate > by > > email as well as username. The idea was shot down rather quickly without > > any particularly good reason. In order for me to continue contributing > to > > the trunk I'd like to get in line with the thought processes on Django > > development. Could someone here please elaborate on why ticket 7591 is a > > bad idea? Or better yet why its a worse idea than other approaches? > > > > > > Thanks, > > -- > > - Paul > > > > > > > > > > > -- > ---- > Waylan Limberg > [EMAIL PROTECTED] > > > > -- - Paul Kenjora - 602-214-7285 --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~----------~----~----~----~------~----~------~--~---
