On Tue, 2009-01-20 at 01:54 -0300, Leo Soto M. wrote: [...] > So I've uploaded a small patch on #10071[4] which does the > normalization to int instead of unicode. I tested it with sqlite > (which was the problematic backend) and it doesn't break any test. > > Now, my questions are: > > - Is this change OK or would it be considered as backwards > incompatible for slightly changing the interface with DB backends? On > the pragmatic side I'd like to point that this doesn't break anything > on the built-in backends but it would be good get confirmation from > other external backend developers.
That area of the code was really problematic just before 1.0. I'll dig through my memory and read the changes around that time to try and remember what the tricks were, but I have a recollection we tried to initially go directly to ints and something or other didn't work (something form or admin related). That might not have been the same as the change you're making here, but I'll have a hard think. It might just have been that the change we ended up making was the least intrusive for that point in time and it didn't seem to break anything. There were some people working on this (in person) at the Portland sprint just before 1.0 and my recollection is that the patch they came up with didn't quite work and I had to spend a while tweaking it. Don't know if any of them are on this list, though. > - If the change is OK, could it make it into the 1.0.X branch? That'd > be very good, as we are targeting Django 1.0 on the django-jython > project. I'd call it a bug fix for that reason. Jython support on 1.0 is/was one of our goals. Has something changed that made this only show up now? Or has it always been there and you just didn't notice? Regards, Malcolm --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~----------~----~----~----~------~----~------~--~---
